From ee245fbb79a07e25fc0770e0d59ef6104b699788 Mon Sep 17 00:00:00 2001
From: Syping <syping@syping.de>
Date: Sun, 22 Mar 2026 17:44:23 +0100
Subject: [PATCH] http_request: improve memory safety

---
 src/core/http_request.cpp | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/core/http_request.cpp b/src/core/http_request.cpp
index 0828ac2..6b001fe 100644
--- a/src/core/http_request.cpp
+++ b/src/core/http_request.cpp
@@ -30,9 +30,12 @@ http_response http_request::get(const std::string &url, const dpp::http_headers
     curl_slist *header_slist = nullptr;
     if (!headers.empty()) {
         for (const auto &header : headers) {
-            header_slist = curl_slist_append(header_slist, std::string(header.first + ": " + header.second).c_str());
-            if (!header_slist)
+            curl_slist *new_header_slist = curl_slist_append(header_slist, std::string(header.first + ": " + header.second).c_str());
+            if (!new_header_slist) {
+                curl_slist_free_all(header_slist);
                 throw std::bad_alloc();
+            }
+            header_slist = new_header_slist;
         }
     }
     if (!header_slist)
@@ -52,15 +55,21 @@ http_response http_request::post(const std::string &url, const std::string &cont
     curl_easy_setopt(instance, CURLOPT_URL, url.c_str());
     curl_slist *header_slist = nullptr;
     if (!content_type.empty()) {
-        header_slist = curl_slist_append(header_slist, std::string("Content-Type: " + content_type).c_str());
-        if (!header_slist)
+        curl_slist *new_header_slist = curl_slist_append(header_slist, std::string("Content-Type: " + content_type).c_str());
+        if (!new_header_slist) {
+            curl_slist_free_all(header_slist);
             throw std::bad_alloc();
+        }
+        header_slist = new_header_slist;
     }
     if (!headers.empty()) {
         for (const auto &header : headers) {
-            header_slist = curl_slist_append(header_slist, std::string(header.first + ": " + header.second).c_str());
-            if (!header_slist)
+            curl_slist *new_header_slist = curl_slist_append(header_slist, std::string(header.first + ": " + header.second).c_str());
+            if (!new_header_slist) {
+                curl_slist_free_all(header_slist);
                 throw std::bad_alloc();
+            }
+            header_slist = new_header_slist;
         }
     }
     if (!header_slist)