From d71f3641e248af99cbf422d6dd232aed6eb5171a Mon Sep 17 00:00:00 2001 From: Syping Date: Wed, 20 Oct 2021 08:53:55 +0200 Subject: [PATCH] fix potential iconv memleak --- src/RagePhoto.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/RagePhoto.cpp b/src/RagePhoto.cpp index 17f0f7f..e8c9142 100644 --- a/src/RagePhoto.cpp +++ b/src/RagePhoto.cpp @@ -467,11 +467,11 @@ bool RagePhoto::save(char *data, PhotoFormat photoFormat) char *src = photoString; char *dst = photoHeader; const size_t ret = iconv(iconv_in, &src, &src_s, &dst, &dst_s); + iconv_close(iconv_in); if (ret == static_cast(-1)) { p_error = Error::UnicodeHeaderError; // 5 return false; } - iconv_close(iconv_in); const size_t photoHeader_size = p_photoString.size() * 2; if (photoHeader_size > 256) { p_error = Error::HeaderBufferTight; // 34