Syping/dtranslatebot
1
0
Fork 0
mirror of https://github.com/Syping/dtranslatebot.git synced 2026-04-01 05:20:22 +02:00
Code Issues Projects Releases Packages Wiki Activity

http_headers: improve memory management

Browse source
This commit is contained in:
Syping 2026-03-29 09:29:09 +02:00
parent 3b7264c547
commit b35070f788
2 changed files with 55 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

49
src/core/http_headers.cpp
View file

@ -23,6 +23,10 @@ http_headers::http_headers() {
instance = nullptr; instance = nullptr;
} }
http_headers::http_headers(const http_headers &headers) {
instance = copy_from(headers.data());
}
http_headers::http_headers(const std::string &field, const std::string &value) { http_headers::http_headers(const std::string &field, const std::string &value) {
instance = nullptr; instance = nullptr;
add(field, value); add(field, value);
@ -35,18 +39,50 @@ http_headers::http_headers(const http_header &header) {
http_headers::http_headers(const std::initializer_list<http_header> &headers) { http_headers::http_headers(const std::initializer_list<http_header> &headers) {
instance = nullptr; instance = nullptr;
try {
add(headers); add(headers);
} }
catch (const std::bad_alloc &exception) {
curl_slist_free_all(instance);
throw;
}
}
http_headers::http_headers(const std::vector<http_header> &headers) { http_headers::http_headers(const std::vector<http_header> &headers) {
instance = nullptr; instance = nullptr;
try {
add(headers); add(headers);
} }
catch (const std::bad_alloc &exception) {
curl_slist_free_all(instance);
throw;
}
}
http_headers::~http_headers() { http_headers::~http_headers() {
curl_slist_free_all(instance); curl_slist_free_all(instance);
} }
http_headers& http_headers::operator=(const curl_slist *other) {
if (this->data() == other)
return *this;
if (curl_slist *headers = copy_from(other)) {
curl_slist_free_all(instance);
instance = headers;
}
return *this;
}
http_headers& http_headers::operator=(const http_headers &other) {
if (this == &other)
return *this;
if (curl_slist *headers = copy_from(other.data())) {
curl_slist_free_all(instance);
instance = headers;
}
return *this;
}
void http_headers::add(const std::string &field, const std::string &value) { void http_headers::add(const std::string &field, const std::string &value) {
const std::string header = field + ": " + value; const std::string header = field + ": " + value;
curl_slist *headers = curl_slist_append(instance, header.c_str()); curl_slist *headers = curl_slist_append(instance, header.c_str());
@ -85,3 +121,16 @@ void http_headers::remove(const std::vector<std::string> &fields) {
const curl_slist* http_headers::data() const { const curl_slist* http_headers::data() const {
return instance; return instance;
} }
curl_slist* http_headers::copy_from(const curl_slist *headers) {
curl_slist *instance = nullptr;
for (const curl_slist *i = headers; i; i = i->next) {
curl_slist *headers = curl_slist_append(instance, i->data);
if (!headers) {
curl_slist_free_all(instance);
throw std::bad_alloc();
}
instance = headers;
}
return instance;
}

4
src/core/http_headers.h
View file

@ -31,11 +31,14 @@ namespace bot {
class http_headers { class http_headers {
public: public:
http_headers(); http_headers();
http_headers(const http_headers &headers);
http_headers(const std::string &field, const std::string &value); http_headers(const std::string &field, const std::string &value);
http_headers(const http_header &header); http_headers(const http_header &header);
http_headers(const std::initializer_list<http_header> &headers); http_headers(const std::initializer_list<http_header> &headers);
http_headers(const std::vector<http_header> &headers); http_headers(const std::vector<http_header> &headers);
~http_headers(); ~http_headers();
http_headers& operator=(const curl_slist *headers);
http_headers& operator=(const http_headers &headers);
void add(const std::string &field, const std::string &value); void add(const std::string &field, const std::string &value);
void add(const http_header &header); void add(const http_header &header);
void add(const std::initializer_list<http_header> &headers); void add(const std::initializer_list<http_header> &headers);
@ -45,6 +48,7 @@ namespace bot {
const curl_slist* data() const; const curl_slist* data() const;
private: private:
static curl_slist* copy_from(const curl_slist *headers);
curl_slist *instance; curl_slist *instance;
}; };
} }