Syping/dtranslatebot
1
0
Fork 0
mirror of https://github.com/Syping/dtranslatebot.git synced 2026-04-01 05:20:22 +02:00
Code Issues Projects Releases Packages Wiki Activity

http_request: improve memory safety

Browse source
This commit is contained in:
Syping 2026-03-22 17:44:23 +01:00
parent cf134599a7
commit ee245fbb79
1 changed files with 15 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/core/http_request.cpp
View file

@ -30,9 +30,12 @@ http_response http_request::get(const std::string &url, const dpp::http_headers
curl_slist *header_slist = nullptr; curl_slist *header_slist = nullptr;
if (!headers.empty()) { if (!headers.empty()) {
for (const auto &header : headers) { for (const auto &header : headers) {
header_slist = curl_slist_append(header_slist, std::string(header.first + ": " + header.second).c_str()); curl_slist *new_header_slist = curl_slist_append(header_slist, std::string(header.first + ": " + header.second).c_str());
if (!header_slist) if (!new_header_slist) {
curl_slist_free_all(header_slist);
throw std::bad_alloc(); throw std::bad_alloc();
}
header_slist = new_header_slist;
} }
} }
if (!header_slist) if (!header_slist)
@ -52,15 +55,21 @@ http_response http_request::post(const std::string &url, const std::string &cont
curl_easy_setopt(instance, CURLOPT_URL, url.c_str()); curl_easy_setopt(instance, CURLOPT_URL, url.c_str());
curl_slist *header_slist = nullptr; curl_slist *header_slist = nullptr;
if (!content_type.empty()) { if (!content_type.empty()) {
header_slist = curl_slist_append(header_slist, std::string("Content-Type: " + content_type).c_str()); curl_slist *new_header_slist = curl_slist_append(header_slist, std::string("Content-Type: " + content_type).c_str());
if (!header_slist) if (!new_header_slist) {
curl_slist_free_all(header_slist);
throw std::bad_alloc(); throw std::bad_alloc();
}
header_slist = new_header_slist;
} }
if (!headers.empty()) { if (!headers.empty()) {
for (const auto &header : headers) { for (const auto &header : headers) {
header_slist = curl_slist_append(header_slist, std::string(header.first + ": " + header.second).c_str()); curl_slist *new_header_slist = curl_slist_append(header_slist, std::string(header.first + ": " + header.second).c_str());
if (!header_slist) if (!new_header_slist) {
curl_slist_free_all(header_slist);
throw std::bad_alloc(); throw std::bad_alloc();
}
header_slist = new_header_slist;
} }
} }
if (!header_slist) if (!header_slist)